lkml.org 
[lkml]   [2020]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] scsi: zfcp: move the position of put_device
On Tue, Dec 01, 2020 at 10:47:16AM +0800, Qinglang Miao wrote:
> Have the `put_device()` call after `device_unregister()` in both
> `zfcp_unit_remove()` and `zfcp_sysfs_port_remove_store()` to make
> it more natural, for put_device() ought to be the last time we
> touch the object in both functions.
>
> And add comments after put_device to make codes clearer.
>
> Suggested-by: Steffen Maier <maier@linux.ibm.com>
> Suggested-by: Benjamin Block <bblock@linux.ibm.com>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> v2: add comments after put_device as Steffen suggested.
>
> drivers/s390/scsi/zfcp_sysfs.c | 4 ++--
> drivers/s390/scsi/zfcp_unit.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>

Got a bit delayed.
Looks good, I queue it, and we send it with the changes for 5.12 once
the merge window for 5.11 is over.

Thanks.

--
Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems
IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy
Vorsitz. AufsR.: Gregor Pillen / Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294

\
 
 \ /
  Last update: 2020-12-14 13:53    [W:0.062 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site