Messages in this thread | | | Date | Thu, 10 Dec 2020 18:21:22 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH v4] pwm: bcm2835: Support apply function for atomic configuration |
| |
On Wed, Dec 09, 2020 at 09:48:25PM +0100, Lino Sanfilippo wrote: > Use the newer .apply function of pwm_ops instead of .config, .enable, > .disable and .set_polarity. This guarantees atomic changes of the pwm > controller configuration. It also reduces the size of the driver. > > Since now period is a 64 bit value, add an extra check to reject periods > that exceed the possible max value for the 32 bit register. > > This has been tested on a Raspberry PI 4. > > Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de> > --- > > v4: Remove a superfluous blank line > Remove an unneeded cast (both requested by Uwe Kleine-König) > v3: Check against period truncation (also based on a review by Uwe) > v2: Fix compiler error for 64 bit builds > > drivers/pwm/pwm-bcm2835.c | 69 +++++++++++++++++------------------------------ > 1 file changed, 24 insertions(+), 45 deletions(-) j
Applied, thanks.
Thierry [unhandled content-type:application/pgp-signature] | |