lkml.org 
[lkml]   [2020]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 52/75] coredump: fix core_pattern parse error
    Date
    From: Menglong Dong <dong.menglong@zte.com.cn>

    commit 2bf509d96d84c3336d08375e8af34d1b85ee71c8 upstream.

    'format_corename()' will splite 'core_pattern' on spaces when it is in
    pipe mode, and take helper_argv[0] as the path to usermode executable.
    It works fine in most cases.

    However, if there is a space between '|' and '/file/path', such as
    '| /usr/lib/systemd/systemd-coredump %P %u %g', then helper_argv[0] will
    be parsed as '', and users will get a 'Core dump to | disabled'.

    It is not friendly to users, as the pattern above was valid previously.
    Fix this by ignoring the spaces between '|' and '/file/path'.

    Fixes: 315c69261dd3 ("coredump: split pipe command whitespace before expanding template")
    Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Cc: Paul Wise <pabs3@bonedaddy.net>
    Cc: Jakub Wilk <jwilk@jwilk.net> [https://bugs.debian.org/924398]
    Cc: Neil Horman <nhorman@tuxdriver.com>
    Cc: <stable@vger.kernel.org>
    Link: https://lkml.kernel.org/r/5fb62870.1c69fb81.8ef5d.af76@mx.google.com
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/coredump.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/fs/coredump.c
    +++ b/fs/coredump.c
    @@ -229,7 +229,8 @@ static int format_corename(struct core_n
    */
    if (ispipe) {
    if (isspace(*pat_ptr)) {
    - was_space = true;
    + if (cn->used != 0)
    + was_space = true;
    pat_ptr++;
    continue;
    } else if (was_space) {

    \
     
     \ /
      Last update: 2020-12-10 15:48    [W:3.618 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site