lkml.org 
[lkml]   [2020]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 9/9] riscv: dts: add initial board data for the SiFive HiFive Unmatched
    On Tue, Dec 8, 2020 at 3:06 PM Yash Shah <yash.shah@sifive.com> wrote:
    >
    > Add initial board data for the SiFive HiFive Unmatched A00.
    > This patch is dependent on Zong's Patchset[0].
    >
    > [0]: https://lore.kernel.org/linux-riscv/20201130082330.77268-4-zong.li@sifive.com/T/#u

    I think the dependency should be put below --, not in the commit message itself

    >
    > Signed-off-by: Yash Shah <yash.shah@sifive.com>
    > ---
    > arch/riscv/boot/dts/sifive/Makefile | 3 +-
    > .../riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 253 +++++++++++++++++++++
    > 2 files changed, 255 insertions(+), 1 deletion(-)
    > create mode 100644 arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
    >
    > diff --git a/arch/riscv/boot/dts/sifive/Makefile b/arch/riscv/boot/dts/sifive/Makefile
    > index 6d6189e..74c47fe 100644
    > --- a/arch/riscv/boot/dts/sifive/Makefile
    > +++ b/arch/riscv/boot/dts/sifive/Makefile
    > @@ -1,2 +1,3 @@
    > # SPDX-License-Identifier: GPL-2.0
    > -dtb-$(CONFIG_SOC_SIFIVE) += hifive-unleashed-a00.dtb
    > +dtb-$(CONFIG_SOC_SIFIVE) += hifive-unleashed-a00.dtb \
    > + hifive-unmatched-a00.dtb

    Otherwise LGTM:
    Reviewed-by: Bin Meng <bin.meng@windriver.com>

    \
     
     \ /
      Last update: 2020-12-10 14:38    [W:2.545 / U:1.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site