Messages in this thread | | | Subject | Re: [PATCH] block: blk-iocost: fix build for ARCH with missing local64.h files | From | Randy Dunlap <> | Date | Wed, 9 Dec 2020 22:16:20 -0800 |
| |
On 12/9/20 10:07 PM, Christoph Hellwig wrote: > On Wed, Dec 09, 2020 at 12:46:57PM -0800, Randy Dunlap wrote: >> When building block/blk-iocost.c on arch/x6x/ or arch/nios2/, the >> build fails due to missing the <asm/local64.h> file. > > Please mark it mandatory-y if the asm-generic version is suitable > for everyone and random pieces of kernel code are supposed to include > it.
include/asm-generic/local64.h has comments about some $arch could do its things better/faster instead of using asm-generic, but no $arch has done that since 2010 when it was added.
Is that conclusive? If it is, why even use mandatory-y? Why not just change all occurrences of <asm/local64.h> to <asm-generic/local64.h> ?
thanks. -- ~Randy
| |