lkml.org 
[lkml]   [2020]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH rdma-next] RDMA/mlx4: remove bogus dev_base_lock usage
On Tue, Dec 08, 2020 at 09:39:28PM +0200, Vladimir Oltean wrote:
> It is not clear what this lock protects. If the authors wanted to ensure
> that "dev" does not disappear, that is impossible, given the following
> code path:
>
> mlx4_ib_netdev_event (under RTNL mutex)
> -> mlx4_ib_scan_netdevs
> -> mlx4_ib_update_qps
>
> Also, the dev_base_lock does not protect dev->dev_addr either.
>
> So it serves no purpose here. Remove it.
>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> drivers/infiniband/hw/mlx4/main.c | 3 ---
> 1 file changed, 3 deletions(-)

Applied to for-next, thanks

Jason

\
 
 \ /
  Last update: 2020-12-10 22:10    [W:0.030 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site