lkml.org 
[lkml]   [2020]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 61/85] iommu/exynos: add missing put_device() call in exynos_iommu_of_xlate()
    Date
    From: Yu Kuai <yukuai3@huawei.com>

    [ Upstream commit 1a26044954a6d1f4d375d5e62392446af663be7a ]

    if of_find_device_by_node() succeed, exynos_iommu_of_xlate() doesn't have
    a corresponding put_device(). Thus add put_device() to fix the exception
    handling for this function implementation.

    Fixes: aa759fd376fb ("iommu/exynos: Add callback for initializing devices from device tree")
    Signed-off-by: Yu Kuai <yukuai3@huawei.com>
    Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
    Link: https://lore.kernel.org/r/20200918011335.909141-1-yukuai3@huawei.com
    Signed-off-by: Joerg Roedel <jroedel@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/iommu/exynos-iommu.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
    index 60c8a56e4a3f8..89f628da148ac 100644
    --- a/drivers/iommu/exynos-iommu.c
    +++ b/drivers/iommu/exynos-iommu.c
    @@ -1295,13 +1295,17 @@ static int exynos_iommu_of_xlate(struct device *dev,
    return -ENODEV;

    data = platform_get_drvdata(sysmmu);
    - if (!data)
    + if (!data) {
    + put_device(&sysmmu->dev);
    return -ENODEV;
    + }

    if (!owner) {
    owner = kzalloc(sizeof(*owner), GFP_KERNEL);
    - if (!owner)
    + if (!owner) {
    + put_device(&sysmmu->dev);
    return -ENOMEM;
    + }

    INIT_LIST_HEAD(&owner->controllers);
    mutex_init(&owner->rpm_lock);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-05 17:33    [W:4.055 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site