lkml.org 
[lkml]   [2020]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 41/57] gpio/aspeed-sgpio: dont enable all interrupts by default
    Date
    From: Jeremy Kerr <jk@codeconstruct.com.au>

    [ Upstream commit bf0d394e885015941ed2d5724c0a6ed8d42dd95e ]

    Currently, the IRQ setup for the SGPIO driver enables all interrupts in
    dual-edge trigger mode. Since the default handler is handle_bad_irq, any
    state change on input GPIOs will trigger bad IRQ warnings.

    This change applies sensible IRQ defaults: single-edge trigger, and all
    IRQs disabled.

    Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
    Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")
    Reviewed-by: Joel Stanley <joel@jms.id.au>
    Acked-by: Andrew Jeffery <andrew@aj.id.au>
    Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpio/sgpio-aspeed.c | 8 +++-----
    1 file changed, 3 insertions(+), 5 deletions(-)

    diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers/gpio/sgpio-aspeed.c
    index 7cd86d5e8dc90..3a5dfb8ded1fb 100644
    --- a/drivers/gpio/sgpio-aspeed.c
    +++ b/drivers/gpio/sgpio-aspeed.c
    @@ -452,17 +452,15 @@ static int aspeed_sgpio_setup_irqs(struct aspeed_sgpio *gpio,
    irq->parents = &gpio->irq;
    irq->num_parents = 1;

    - /* set IRQ settings and Enable Interrupt */
    + /* Apply default IRQ settings */
    for (i = 0; i < ARRAY_SIZE(aspeed_sgpio_banks); i++) {
    bank = &aspeed_sgpio_banks[i];
    /* set falling or level-low irq */
    iowrite32(0x00000000, bank_reg(gpio, bank, reg_irq_type0));
    /* trigger type is edge */
    iowrite32(0x00000000, bank_reg(gpio, bank, reg_irq_type1));
    - /* dual edge trigger mode. */
    - iowrite32(0xffffffff, bank_reg(gpio, bank, reg_irq_type2));
    - /* enable irq */
    - iowrite32(0xffffffff, bank_reg(gpio, bank, reg_irq_enable));
    + /* single edge trigger */
    + iowrite32(0x00000000, bank_reg(gpio, bank, reg_irq_type2));
    }

    return 0;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-10-05 17:30    [W:6.696 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site