Messages in this thread | | | Date | Mon, 05 Oct 2020 13:59:52 +0100 | From | Marc Zyngier <> | Subject | Re: [PATCH 2/3] soc/tegra: pmc: Allow optional irq parent callbacks |
| |
On 2020-10-05 12:27, Thierry Reding wrote: > On Mon, Oct 05, 2020 at 12:14:42PM +0100, Marc Zyngier wrote: >> Make the PMC driver resistent to variable depth interrupt hierarchy, >> which we are about to introduce. The irq_chip structure is now >> allocated statically, providing the indirection for the couple of >> callbacks that are SoC-specific. >> >> Signed-off-by: Marc Zyngier <maz@kernel.org> >> --- >> drivers/soc/tegra/pmc.c | 65 >> ++++++++++++++++++++++++++++++++++------- >> 1 file changed, 54 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c >> index d332e5d9abac..9960f7c18431 100644 >> --- a/drivers/soc/tegra/pmc.c >> +++ b/drivers/soc/tegra/pmc.c >> @@ -439,7 +439,6 @@ struct tegra_pmc { >> struct pinctrl_dev *pctl_dev; >> >> struct irq_domain *domain; >> - struct irq_chip irq; > > Did you have any particular reason for pulling this out of the struct > tegra_pmc and making it a global variable?
The main reason is that it really isn't per-PMC. You can do everything with a single one that is used even if you have multiple PMCs of different types (not sure that's possible with the current HW, but still).
M. -- Jazz is not dead. It just smells funny...
| |