Messages in this thread | | | Subject | Re: [Fwd: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms] | From | Joe Perches <> | Date | Thu, 25 Jul 2019 06:50:34 -0700 |
| |
On Wed, 2019-07-24 at 20:42 -0500, Julia Lawall wrote: > New version. I check for non-use of the return value of strlcpy and > address some issues that affected the matching of the case where the first > argument involves a pointer dereference. Actually, an isomorphism now > takes care of that case, so it doesn't show up in the semantic patch > explicitly any more. > > julia
Nice x 2, thanks again.
More comments:
@@ identifier f,i2,i1; struct i1 e1; expression e2; local idexpression x; position r.p; @@ ( -x = strlcpy +stracpy (e1.f, e2 - , i2 )@p; ... when != x
Just for completeness and correctness, as I at least don't find an existing use:
Perhaps this "x =" should also include += and + and the various other operators that are possible or does SmPL grammar already do that?
Also, it might be nice to include the trivial conversion with sizeof(e1) and ARRAY_SIZE(e1) so a single script could be run over the kernel.
I'll see about adding that and try it myself so an automated conversion should be possible.
| |