Messages in this thread | | | Date | Thu, 25 Jul 2019 15:42:09 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: dsa: Check existence of .port_mdb_add callback before calling it |
| |
On Wed, Jul 24, 2019 at 11:47:02AM +0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai <wens@csie.org> > > With the recent addition of commit 75dad2520fc3 ("net: dsa: b53: Disable > all ports on setup"), users of b53 (BCM53125 on Lamobo R1 in my case) > are forced to use the dsa subsystem to enable the switch, instead of > having it in the default transparent "forward-to-all" mode.
Hi Chen-Yu
I would do the check earlier, at the beginning of dsa_switch_mdb_add(). It is then similar to dsa_switch_mdb_del().
Andrew
| |