lkml.org 
[lkml]   [2019]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 178/271] crypto: crypto4xx - fix blocksize for cfb and ofb
    Date
    From: Christian Lamparter <chunkeey@gmail.com>

    commit 70c4997f34b6c6888b3ac157adec49e01d0df2d5 upstream.

    While the hardware consider them to be blockciphers, the
    reference implementation defines them as streamciphers.

    Do the right thing and set the blocksize to 1. This
    was found by CONFIG_CRYPTO_MANAGER_EXTRA_TESTS.

    This fixes the following issues:
    skcipher: blocksize for ofb-aes-ppc4xx (16) doesn't match generic impl (1)
    skcipher: blocksize for cfb-aes-ppc4xx (16) doesn't match generic impl (1)

    Cc: Eric Biggers <ebiggers@kernel.org>
    Cc: stable@vger.kernel.org
    Fixes: f2a13e7cba9e ("crypto: crypto4xx - enable AES RFC3686, ECB, CFB and OFB offloads")
    Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/crypto/amcc/crypto4xx_core.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/crypto/amcc/crypto4xx_core.c
    +++ b/drivers/crypto/amcc/crypto4xx_core.c
    @@ -1226,7 +1226,7 @@ static struct crypto4xx_alg_common crypt
    .cra_priority = CRYPTO4XX_CRYPTO_PRIORITY,
    .cra_flags = CRYPTO_ALG_ASYNC |
    CRYPTO_ALG_KERN_DRIVER_ONLY,
    - .cra_blocksize = AES_BLOCK_SIZE,
    + .cra_blocksize = 1,
    .cra_ctxsize = sizeof(struct crypto4xx_ctx),
    .cra_module = THIS_MODULE,
    },
    @@ -1245,7 +1245,7 @@ static struct crypto4xx_alg_common crypt
    .cra_priority = CRYPTO4XX_CRYPTO_PRIORITY,
    .cra_flags = CRYPTO_ALG_ASYNC |
    CRYPTO_ALG_KERN_DRIVER_ONLY,
    - .cra_blocksize = AES_BLOCK_SIZE,
    + .cra_blocksize = 1,
    .cra_ctxsize = sizeof(struct crypto4xx_ctx),
    .cra_module = THIS_MODULE,
    },

    \
     
     \ /
      Last update: 2019-07-25 07:52    [W:3.003 / U:1.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site