Messages in this thread | | | Date | Mon, 30 Sep 2013 18:41:41 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] rwsem: reduce spinlock contention in wakeup code path |
| |
On Mon, Sep 30, 2013 at 09:13:52AM -0700, Linus Torvalds wrote:
> So unlike a lot of other "let's try to make our locking fancy" that I > dislike because it tends to hide the fundamental problem of > contention, the rwlock patches make me go "those actually _fix_ a > fundamental problem".
So here I'm slightly disagreeing; fixing a fundamental problem would be coming up a better anon_vma management that doesn't create such immense chains.
Its still the same lock, spinlock or not.
And regardless of if we keep anon_vma lock a rwsem or not; I think we should merge those rwsem patches as they do improve the lock implementation and the hard work has already been done.
However the biggest ugly by far here is that mm_take_all_locks() thing; couldn't we implement that by basically freezing all tasks referencing that mm?
| |