Messages in this thread | | | Date | Mon, 30 Sep 2013 15:25:10 +0200 | From | Michal Simek <> | Subject | Re: [PATCH 2/3] i2c: xilinx: Set tx direction in write operation |
| |
On 09/30/2013 12:22 PM, Wolfram Sang wrote: > On Mon, Sep 30, 2013 at 11:08:51AM +0200, Michal Simek wrote: >> From: Kedareswara rao Appana <appana.durga.rao@xilinx.com> >> >> In write operation, after filling address byte to tx fifo, >> set the direction of transfer to tx using control register. > > You describe WHAT you do, yet you should describe WHY the change is > needed. For example, I can't tell if this is an urgent bugfix or not. > Please rephrase. >
Will do.
Thanks, Michal
-- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[unhandled content-type:application/pgp-signature] | |