Messages in this thread | | | Date | Tue, 3 May 2011 12:15:10 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 2/2] watchdog: add support for MOXA V2100 watchdog driver |
| |
> Hmm, code in a header? Can't this go into the main source? Hmm, at least > it87_wdt.c has something very similar. Maybe it can even be shared? What > about locking BTW?
The spinlock handles it if you look at the caller points, because you have to own the super I/O and select it each time.
Ultimately it wants to be using request_muxed_* but that isn't in any of the mainstream code yet so can be done in the future when the mux patches go in.
Alan
| |