Messages in this thread | | | Date | Tue, 3 May 2011 08:40:46 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/4] perf: Add persistent event facilities |
| |
* Borislav Petkov <bp@amd64.org> wrote:
> From: Borislav Petkov <borislav.petkov@amd.com> > > Add a barebones implementation for registering persistent events with > perf. For that, we don't destroy the buffers when they're unmapped; > also, we map them read-only so that multiple agents can access them. > > Signed-off-by: Borislav Petkov <borislav.petkov@amd.com> > --- > include/linux/perf_event.h | 22 +++++++++++++++- > kernel/events/Makefile | 2 +- > kernel/events/core.c | 29 ++++++++++++++++++--- > kernel/events/persistent.c | 59 ++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 105 insertions(+), 7 deletions(-) > create mode 100644 kernel/events/persistent.c
I really like this new kernel/events/ subdirectory you created - we could move the other perf_events.c facilities there as well, and maybe split up the file a bit, it's 7.5 KLOC now which is a bit excessive.
We should probably do that before adding kernel/events/persistent.c - wanna do those changes? Initial commit should be a mostly-rename thing: kernel/perf_events.c could move into kernel/events/core.c or so - and then we could split the core up some more, into various facilities.
[ kernel/hw_breakpoint.c could possibly move into kernel/events/hw_breakpoint.c file as well - if Frederic acks it. ]
Thanks,
Ingo
| |