lkml.org 
[lkml]   [2011]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] regulator: Remove mc13xxx_unlock in regulator_register failure path
hi Mark,
> This feels painful, we shouldn't have to be faffing about with the lock
> like this for basic I/O operations.  It feels like we should be pushing
> the lock down into the register access functions - looking at the driver
> I can't really see any reason why all this stuff is being done by hand,
> especially when we've got explicit read/modify/write bitmask operations.
>

Agreed. Thanks for the review. I'll send a patch for it.

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-05-03 18:29    [W:0.023 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site