Messages in this thread | ![/](/images/icornerl.gif) | | From | Axel Lin <> | Date | Wed, 4 May 2011 00:25:54 +0800 | Subject | Re: [PATCH] regulator: Remove mc13xxx_unlock in regulator_register failure path |
| |
hi Mark, > This feels painful, we shouldn't have to be faffing about with the lock > like this for basic I/O operations. It feels like we should be pushing > the lock down into the register access functions - looking at the driver > I can't really see any reason why all this stuff is being done by hand, > especially when we've got explicit read/modify/write bitmask operations. >
Agreed. Thanks for the review. I'll send a patch for it.
Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |