Messages in this thread | | | Subject | Re: [PATCH 3/4] x86, mce: Add persistent MCE event | From | Joe Perches <> | Date | Tue, 03 May 2011 08:32:19 -0700 |
| |
On Tue, 2011-05-03 at 17:22 +0200, Borislav Petkov wrote: > On Tue, May 03, 2011 at 11:14:16AM -0400, Joe Perches wrote: > > On Tue, 2011-05-03 at 09:18 +0200, Borislav Petkov wrote: > > > On Tue, May 03, 2011 at 02:44:01AM -0400, Ingo Molnar wrote: > > > > * Borislav Petkov <bp@amd64.org> wrote: > > [] > > > > > +static struct dentry *mce_add_event_debugfs(struct perf_event *event, int cpu) > > > > > +{ > > > > > + char buf[14]; > > > > > + > > > > > + sprintf(buf, "mce_record%d", cpu); > > trivia: > > buf[14] doesn't fit 10k+ cpus. > I'll fix that when someone comes up with a x86 system that supports 10k+ > CPUs with a single system image :).
Your choice.
I think leaving trivially fixable known defects around isn't good engineering, but maybe that's just me.
| |