Messages in this thread | | | Date | Tue, 3 May 2011 07:13:45 -0700 | From | Greg KH <> | Subject | Re: [RFC 1/5] platform-drivers-x86: add support for Technologic Systems TS-5xxx detection |
| |
On Tue, May 03, 2011 at 10:39:19AM +0100, Alan Cox wrote: > > > I had a look at other drivers, and /sys/devices/platform/ts/ seems to be > > > a good place to hold those entries (one per options as you suggested). > > > Do you agree with that? > > > > No, this is not a platform device, is it? Only platform devices go > > there, and I really doubt you have many of them for this board. > > It seems analogous to some of the laptop helpers so I don't think it is > that unreasonable to make the board config a platform device of its own - > we don't really have a general solution to the board as a device, so if > you look at equivalents on laptops and the like we have assorted platform > control interfaces that are platform devices.
Platform control devices are great, I have no objection to that. I do object to random proc files to try to describe the fact that this board has a rs232 port on it, when that is able to be determined elsewhere.
thanks,
greg k-h
| |