Messages in this thread | | | From | Mike Frysinger <> | Date | Thu, 28 Oct 2010 16:53:22 -0400 | Subject | Re: [PATCH] initramfs: Fix build break on symbol-prefixed archs |
| |
On Thu, Oct 28, 2010 at 16:42, Mike Frysinger wrote: > On Thu, Oct 28, 2010 at 16:35, Sam Ravnborg wrote: >> On Thu, Oct 28, 2010 at 12:46:31AM +0200, Michal Marek wrote: >>> On 27.10.2010 20:23, Mike Frysinger wrote: >>> > can we get this change dropped from linux-next until someone gets a >>> > chance to fix it ? >>> >>> Sorry I missed this thread. So your last patch >>> (http://lkml.org/lkml/2010/10/19/488) did fix the Blackfin build >>> failure? Can you submit it with a proper Signed-off-by and changelog? >> >> Did you see the patch I posted in: http://lkml.org/lkml/2010/10/19/534 >> >> The one that fix up the cppflags usage. >> >> I think this will solve the issue with blackfin nicely - and >> make use of cppflags more as expected. > > but then i followed up that the Makefile code exists to strip out > quotes because the CPP cannot do it for us and we need a value sans > quotes: > http://lkml.org/lkml/2010/10/19/538
for due diligence, adding those two changes breaks building like so: LD .tmp_vmlinux1 .../bfin-uclinux/bin/ld.real: cannot find _ make: *** [.tmp_vmlinux1] Error 1
and if we look at the generated vmlinux.lds, we indeed see the quotes causing problems: . = ALIGN(8); "_"__lock_text_start = .; *(.spinlock.text) "_"__lock_text_end = .; . = ALIGN(8); "_"__kprobes_text_start = .; *(.kprobes.text) "_"__kprobes_text_end = .; -mike
| |