lkml.org 
[lkml]   [2010]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] via-velocity: Codestyle fixes
    Date
    Hi Joe,

    Thanks for that very quick review, this is my first kernel patch.

    On Thu, 28 Oct 2010, you wrote:
    > On Thu, 2010-10-28 at 13:48 +1000, alex@wigen.net wrote:
    > > From: Alexander Wigen <alex@wigen.net>
    > > @@ -1542,7 +1542,7 @@ static int velocity_alloc_rx_buf(struct
    > > velocity_info *vptr, int idx)
    > >
    > > * Fill in the descriptor to match
    > > */
    > >
    > > - *((u32 *) & (rd->rdesc0)) = 0;
    > > + *((u32 *) &(rd->rdesc0)) = 0;
    >
    > I think this style change isn't really that good.
    > rdesc0 is:
    >
    > struct rdesc0 {
    > __le16 RSR; /* Receive status */
    > __le16 len; /* bits 0--13; bit 15 - owner */
    > };
    >
    > I think it more sensible to either set the fields
    > in the struct to 0 or to memset the struct to 0.

    Not sure what is best so I reverted the change.

    > > @@ -1681,7 +1681,7 @@ static int velocity_init_td_ring(struct
    > > velocity_info *vptr)
    > >
    > > static void velocity_free_dma_rings(struct velocity_info *vptr)
    > > {
    > >
    > > const int size = vptr->options.numrx * sizeof(struct rx_desc) +
    > >
    > > - vptr->options.numtx * sizeof(struct tx_desc) * vptr->tx.numq;
    > > + vptr->options.numtx * sizeof(struct tx_desc) *vptr->tx.numq;
    >
    > If checkpatch warns about this, it's wrong.

    It does produce a error acctually, but I have reverted the change:

    drivers/net/via-velocity.c:1684: ERROR: space prohibited after that '*'
    (ctx:WxW)


    >
    > > @@ -2477,24 +2477,24 @@ static struct net_device_stats
    > > *velocity_get_stats(struct net_device *dev)
    > >
    > > dev->stats.rx_errors = vptr->mib_counter[HW_MIB_ifRxErrorPkts];
    > > dev->stats.rx_length_errors =
    > > vptr->mib_counter[HW_MIB_ifInRangeLengthErrors];
    > >
    > > -// unsigned long rx_dropped; /* no space in linux buffers */
    > > +/* unsigned long rx_dropped; /* no space in linux buffers */
    >
    > why not just remove all these commented-out lines?

    Done.

    > > @@ -2957,7 +2957,7 @@ static int velocity_set_wol(struct velocity_info
    > > *vptr)
    > >
    > > memcpy(arp->ar_tip, vptr->ip_addr, 4);
    > >
    > > crc = wol_calc_crc((sizeof(struct arp_packet) + 7) / 8, buf,
    > >
    > > - (u8 *) & mask_pattern[0][0]);
    > > + (u8 *) &mask_pattern[0][0]);
    >
    > perhaps just (u8 *)mask_pattern?
    >
    > > @@ -3454,7 +3453,7 @@ static const struct ethtool_ops
    > > velocity_ethtool_ops = {
    > >
    > > .set_wol = velocity_ethtool_set_wol,
    > > .get_msglevel = velocity_get_msglevel,
    > > .set_msglevel = velocity_set_msglevel,
    > >
    > > - .set_sg = ethtool_op_set_sg,
    > > + .set_sg = ethtool_op_set_sg,
    >
    > bad alignment?

    Sorry, wrong editor tab width.

    Cheers,
    Alexander Wigen


    \
     
     \ /
      Last update: 2010-10-28 07:39    [W:2.455 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site