lkml.org 
[lkml]   [2008]   [Jul]   [29]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 29 Jul 2008 01:41:33 -0400
FromDmitry Torokhov <>
SubjectRe: [PATCH] bcm5974-0.58: name changes, open/close and suspend/resume serialized
Hi Henrik,

On Sat, Jul 26, 2008 at 09:49:38AM +0200, Henrik Rydberg wrote:
> Hi Dmitry,
> 
> one thing about the drivers/input/mouse/Kconfig patch:
> 
> The original version contained "select USB", which was later changed
> to "depends on USB" by Andrew Morton. I saw it reappear as "select USB"
> in your latest patch, and simply considered it a change back, but
> maybe it was an oversight?
> 

I am of the opinion that it is OK to "select" high-level subsystems that
don't have additional dependencies, especially if they are "past" the
original driver in menuconfig. I don't really like the idea of forcing
users revisiting earlier sub-menus after they selected a new subsystem
to see if there are any new options. Plus, if user wants driver for his
touchpad he does not really care whether it is PS/2 or USB, [s]he just
wants it to work.

So the change was intentional on my part.

-- 
Dmitry


\
 
 \ /
  Last update: 2008-07-29 07:45    [from the cache]
©2003-2008