lkml.org 
[lkml]   [2008]   [Jul]   [28]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
From kamezawa.hiroyu@jp ...
DateMon, 28 Jul 2008 17:39:14 +0900 (JST)
SubjectRe: Re: [PATCH 1/2][-mm][resend] res_counter limit change support ebusy
----- Original Message -----
>On Mon, 14 Jul 2008 17:11:54 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fuji
tsu.com> wrote:
>> +static inline int res_counter_set_limit(struct res_counter *cnt,
>> +	unsigned long long limit)
>> +{
>> +	unsigned long flags;
>> +	int ret = -EBUSY;
>> +
>> +	spin_lock_irqsave(&cnt->lock, flags);
>> +	if (cnt->usage < limit) {
>> +		cnt->limit = limit;
>> +		ret = 0;
>> +	}
>> +	spin_unlock_irqrestore(&cnt->lock, flags);
>> +	return ret;
>> +}
>
>Need I say it?  This function is waaaaaay too large to be inlined.

Will rework and make this uninlined. (in this week)

Thanks,
-Kame



\
 
 \ /
  Last update: 2008-07-28 10:57    [from the cache]
©2003-2008