Messages in this thread |  | | | Date | Mon, 28 Jul 2008 01:53:13 -0700 | | From | Andrew Morton <> | | Subject | Re: [PATCH 2/2][-mm][resend] memcg limit change shrink usage. | |
On Mon, 28 Jul 2008 17:43:22 +0900 (JST) kamezawa.hiroyu@jp.fujitsu.com wrote:
> >Guys, this is core Linux kernel, not some weekend hack project. Please
> >work to make it as comprehensible and as maintainable as we possibly
> >can.
> >
> >Also, it is frequently a mistake for a callee to assume that the caller
> >can use GFP_KERNEL. Often when we do this we end having to change the
> >interface so that the caller passes in the gfp_t. As there's only one
> >caller I guess we can get away with it this time. For now.
> >
>
> Hmm, ok. will rework this and take gfp_t as an argument.
I don't think it's necessary, really. I was just talking to myself ;)
|  |