lkml.org 
[lkml]   [2008]   [Jul]   [12]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 12 Jul 2008 11:43:22 +0400
FromCyrill Gorcunov <>
SubjectRe: [PATCH -tip] x86: apic LVTT - use APIC_DIVISOR on 64bit mode
[Ingo Molnar - Sat, Jul 12, 2008 at 09:39:10AM +0200]
| 
| * Cyrill Gorcunov <gorcunov@gmail.com> wrote:
| 
| > @@ -329,7 +332,7 @@ static void __init calibrate_APIC_clock(
| >  	 *
| >  	 * No interrupt enable !
| >  	 */
| > -	__setup_APIC_LVTT(250000000, 0, 0);
| > +	__setup_APIC_LVTT(4000000000, 0, 0);
| 
| note how close it is to 2^32. For this to be unifiable later on this 
| needs to be UL i guess, and this:
| 
| > -	calibration_result = result / HZ;
| > +	calibration_result = result * APIC_DIVISOR / HZ;
| 
| might overflow 32 bits.
| 
| 	Ingo
|

hmm... I need more time for analisys, thanks. Drop this patch
please

		- Cyrill -


\
 
 \ /
  Last update: 2008-07-12 09:45    [from the cache]
©2003-2008