Messages in this thread |  | | | Date | Tue, 1 Jul 2008 10:17:35 +0300 | | From | Adrian Bunk <> | | Subject | Re: -Wmissing-prototypes (was: make foo() static) | |
On Tue, Jul 01, 2008 at 08:42:59AM +0200, Gerd Hoffmann wrote:
> Adrian Bunk wrote:
>
> > This patch makes the needlessly global kvm_smp_prepare_boot_cpu() static.
>
> Hmm, maybe we should build the kernel with -Wmissing-prototypes?
> That should make gcc print a warning for that ...
I started 3 or 4 years ago cleaning up the kernel for
-Wmissing-prototypes and I'm still working on it.
Many parts of the kernel now compile cleanly or nearly cleanly, but
looking at e.g. arch/ I know what kind of answers I would get if
suggesting adding -Wmissing-prototypes today...
> cheers,
> Gerd
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
|  |