Messages in this thread Patch in this message | | | Date | Sat, 6 Jan 2007 22:19:47 -0800 | From | Randy Dunlap <> | Subject | [PATCH] math-emu/setcc: avoid gcc extension |
| |
From: Randy Dunlap <randy.dunlap@oracle.com>
setcc() in math-emu is written as a gcc extension statement expression macro that returns a value. However, it's not used that way and it's not needed like that, so just make it a do-while non-extension macro so that we don't use an extension when it's not needed.
All 4 .c files that use setcc() produce the same code after this patch.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- arch/i386/math-emu/status_w.h | 5 +++--
--- arch/i386/math-emu/status_w.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-2620-rc2.orig/arch/i386/math-emu/status_w.h +++ linux-2620-rc2/arch/i386/math-emu/status_w.h @@ -48,9 +48,10 @@ #define status_word() \ ((partial_status & ~SW_Top & 0xffff) | ((top << SW_Top_Shift) & SW_Top)) -#define setcc(cc) ({ \ +#define setcc(cc) do { \ partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \ - partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); }) + partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); } \ + while (0) #ifdef PECULIAR_486 /* Default, this conveys no information, but an 80486 does it. */
--- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |