Messages in this thread | | | Date | Mon, 8 Jan 2007 06:26:57 +0200 | Subject | Re: [PATCH 2.6.20-rc3] UCC Ether driver: kmalloc casting cleanups | From | "Ahmed S. Darwish" <> |
| |
On Mon, Jan 08, 2007 at 11:12:28AM +0800, Li Yang-r58472 wrote: > > From: Ahmed S. Darwish [mailto:darwish.07@gmail.com] > > > > Hi, > > A kmalloc casting cleanup patch. > > Signed-off-by: Ahmed Darwish <darwish.07@gmail.com>
[..]
> > - (u32) (kmalloc((u32) (length + align), > > - GFP_KERNEL)); > > + kmalloc((u32) (length + align), GFP_KERNEL); > > + > > if (ugeth->tx_bd_ring_offset[j] != 0) > > ugeth->p_tx_bd_ring[j] =
[..]
> > - (u32) (kmalloc((u32) (length + align), GFP_KERNEL)); > > + kmalloc((u32) (length + align), GFP_KERNEL); > > NACK about the 2 clean-ups above. Cast from pointer to integer is > required here.
Are the casts from pointer to integer just needed to suppress gcc warnings or there's something technically important about them ?
I'll send the modified patch without the NACKed parts in minutes ..
-- Ahmed S. Darwish http://darwish-07.blogspot.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |