Messages in this thread | | | Subject | Re: [PATCH] increment pos before looking for the next cap in __pci_find_next_ht_cap | From | Michael Ellerman <> | Date | Mon, 08 Jan 2007 10:37:10 +1100 |
| |
On Fri, 2007-01-05 at 17:58 -0600, Robert Hancock wrote: > Brice Goglin wrote: > > Hi, > > > > While testing 2.6.20-rc3 on a machine with some CK804 chipsets, we > > noticed that quirk_nvidia_ck804_msi_ht_cap() was not detecting HT > > MSI capabilities anymore. It is actually caused by the MSI mapping > > on the root chipset being the 2nd HT capability in the chain. > > pci_find_ht_capability() does not seem to find anything but the > > first HT cap correctly, because it forgets to increment the position > > before looking for the next cap. The following patch seems to fix it. > > > > At least, this prooves that having a ttl is good idea since the > > machine would have been stucked in an infinite loop if we didn't > > have a ttl :) > > > > The patch should go in 2.6.20 since this quirk was working fine in 2.6.19. > > Yes, I saw this on my A8N-SLI Deluxe board as well. This is a regression > since MSI is being disabled on the PCI Express slots when it wasn't before.. >
Guilty as charged :/
cheers
-- Michael Ellerman OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person [unhandled content-type:application/pgp-signature] | |