Messages in this thread | | | Date | Sat, 9 Dec 2006 12:59:58 +0100 | From | Holger Macht <> | Subject | Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver. |
| |
On Mon 04. Dec - 14:49:58, Kristen Carlson Accardi wrote: > From: brandon@ifup.org > > Add 2 sysfs files for user interface. > 1) docked - 1/0 (read only) - indicates whether the software believes the > laptop is docked in a docking station. > 2) undock - (write only) - writing to this file causes the software to > initiate an undock request to the firmware.
Thanks for doin this!
However, the function dock_event(...) still contains this comment:
/* * we don't do events until someone tells me that * they would like to have them. */
Well, I like to have them ;-)
The sysfs exports are more or less useless without events. When the dock driver is loaded, you get a platform device below /sys. But you never know if there will ever be a docking station connected to your system. Userspace caring about this will have to poll the 'docked' file, which is obviously bad.
Thanks, Holger - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |