Messages in this thread | | | Date | Fri, 08 Dec 2006 06:03:59 -0700 | From | Rocky Craig <> | Subject | Re: [PATCH 11/12] IPMI: Fix BT long busy |
| |
Andrew Morton wrote:
>In fact, please don't write macros. > > I see them all over the place (i.e., EXPORT_SYMBOL) so the request is a little confusing to me...
> Please don't write macros which require that the caller have a particular > >local variable of a particular name. > > I could understand that, even if some people did agree with my desire to increase legibility by decreasing visual clutter. I think it also provides some protection against typos in argument lists.
I'm (naively) curious as to why it's being flagged now as opposed to two years ago when I submitted the original additions.
Have reviewers or review methods changed?
Have standards changed?
Did it just slip under someone's radar two years ago?
Regards, Rocky Craig HP Open Source and Linux Organization - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |