lkml.org 
[lkml]   [2006]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: cmpxchg() in kernel/workqueue.c breaks things
    Date
    Andrew Morton <akpm@osdl.org> wrote:

    > I don't see why the 2.6.19 logic needed changing.
    >
    > a) Nobody should be freeing the work_struct itself without running
    > flush_scheduled_work() and
    >
    > b) even if the work_struct _did_ get freed, the callback function won't
    > care, because there's nothing in that work_struct which it's interested
    > in.

    Erm... Did you mean that in reply to my suggestion that we don't need to use
    cmpxchg()?

    We might want to avoid cmpxchg() because it isn't available on all platforms
    under all circumstances, and besides I'm not sure it's actually necessary.

    David
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-07 12:49    [W:4.473 / U:0.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site