Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: Infinite retries reading the partition table | From | James Bottomley <> | Date | Thu, 07 Dec 2006 15:15:03 -0600 |
| |
On Thu, 2006-12-07 at 11:14 -0800, Luben Tuikov wrote: > It is. If good_bytes=0 then nothing is up to date and uptodate should > be set to 0.
That's not a correct assumption. Zero transfer commands, like TEST UNIT READY are perfectly happy to complete successfully with good_bytes == 0.
> Look at my comment before the function call: > /* A number of bytes were successfully read. ... > > I repeat again: it doesn't make sense to call scsi_end_request > with uptodate=1 and good_bytes=0, since _no bytes are uptodate_.
We can certainly debate that, but it's not appropriate to do it as part of an unrelated patch.
James
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |