lkml.org 
[lkml]   [2006]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Export current_is_keventd() for libphy
    On Thu, 7 Dec 2006 09:57:15 -0800
    Andrew Morton <akpm@osdl.org> wrote:

    > On Thu, 07 Dec 2006 12:05:38 -0500
    > Jeff Garzik <jeff@garzik.org> wrote:
    >
    > > Yes, I merged the code, but looking deeper at phy its clear I missed
    > > some things.
    > >
    > > Looking into libphy's workqueue stuff, it has the following sequence:
    > >
    > > disable interrupts
    > > schedule_work()
    > >
    > > ... time passes ...
    > > ... workqueue routine is called ...
    > >
    > > enable interrupts
    > > handle interrupt
    > >
    > > I really have to question if a workqueue was the best choice of
    > > direction for such a sequence. You don't want to put off handling an
    > > interrupt, with interrupts disabled, for a potentially unbounded amount
    > > of time.
    >
    > That'll lock the box on UP, or if the timer fires on the current CPU?

    oh. "disable interrupts" == disable_irq(), not local_irq_disable()?

    Not so bad ;)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-07 19:23    [W:7.004 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site