Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 6 Dec 2006 22:20:22 -0800 | From | "Matt Reimer" <> | Subject | Re: [PATCH] mm: D-cache aliasing issue in cow_user_page |
| |
On 12/6/06, David Miller <davem@davemloft.net> wrote: > From: "Matt Reimer" <mattjreimer@gmail.com> > Date: Wed, 6 Dec 2006 13:19:41 -0800 > > > On 12/5/06, David Miller <davem@davemloft.net> wrote: > > > From: "Matt Reimer" <mattjreimer@gmail.com> > > > Date: Tue, 5 Dec 2006 16:57:12 -0800 > > > > > > > Right, but isn't he declaring that each architecture needs to take > > > > care of this? So, say, on ARM we'd need to make kunmap() not a NOP and > > > > call flush_dcache_page() ? > > > > > > No. He is only solving a problem that occurs on HIGHMEM > > > configurations on systems which can have D-cache aliasing > > > issues. > > > > Are you sure? James specifically mentions "non-highmem architectures," > > and "all architectures with coherence issues," which would seem to > > include ARM (which is my concern). > > > > For your convenience I quote the whole commit message below. > > Ok, I see. > > He's providing it an alternative way to solve the coherency > issues. > > You can still solve it the traditional way via cache flushing > in flush_dcache_page() and {copy,clear}_user_page().
Ok, good to know, since that's what we're doing with ARM drivers presently. What's the preferred method going forward?
If architectures with coherency problems have to take care of this in their kmap() implementations, wouldn't commits like [1] below result in a pessmization for these architectures, since effectively the flush would happen twice (once by architecture-specific kunmap, and once by the flush_dcache_page() being added in this commit)?
Matt
[1] http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c4ec7b0de4bc18ccb4380de638550984d9a65c25 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |