Messages in this thread | | | Date | Wed, 6 Dec 2006 09:58:09 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [PATCH] Export current_is_keventd() for libphy |
| |
On Wed, 6 Dec 2006, Linus Torvalds wrote: > > Gcc should do it for us, afaik. I didn't check, but gcc is generally > pretty good at combining logical operations like this, because it's very > common.
Sadly, gcc doesn't do it in this case. Still, I'd rather keep the source clean, and hope that the compiler improves eventually, than to make the code uglier.
I replaced both of the "test_bit(WORK_STRUCT_PENDING, &work->management)" with "work_pending(work)" in my tree.
Now somebody who knows how to trigger this thing should just _test_ it.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |