lkml.org 
[lkml]   [2006]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Relative atime (was Re: What's in ocfs2.git)
On Tue, 5 Dec 2006 14:20:27 -0800
Mark Fasheh <mark.fasheh@oracle.com> wrote:

> Update ocfs2_should_update_atime() to understand the MNT_RELATIME flag and
> to test against mtime / ctime accordingly.
>
> ...
>
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -154,6 +154,15 @@ int ocfs2_should_update_atime(struct ino
> return 0;
>
> now = CURRENT_TIME;
> +
> + if (vfsmnt->mnt_flags & MNT_RELATIME) {
> + if ((timespec_compare(&inode->i_atime, &inode->i_mtime) < 0) ||
> + (timespec_compare(&inode->i_atime, &inode->i_ctime) < 0))
> + return 1;
> +
> + return 0;

So if atime == mtime == ctime, we don't update the atime.

I think we should. It seems risky to leave them all equal.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-06 07:15    [W:0.069 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site