Messages in this thread | | | Subject | Re: [PATCH 0/3] New firewire stack | From | Benjamin Herrenschmidt <> | Date | Wed, 06 Dec 2006 08:41:49 +1100 |
| |
On Tue, 2006-12-05 at 19:49 +0100, Stefan Richter wrote: > Kristian Høgsberg wrote: > > David Miller wrote: > >> From: Benjamin Herrenschmidt <benh@kernel.crashing.org> > >>> DO NOT USE BITFIELDS FOR DATA ON THE WIRE !!! > > Actually we do so in some places of the existing FireWire drivers. > Didn't go wrong so far. :-)
Yeah, because you used
#if defined __BIG_ENDIAN_BITFIELD
and
#if defined __LITTLE_ENDIAN_BITFIELD
which relies on the fact that it -seems- that by luck, gcc only has two representations around and they match little/big endian archs (though have we verified that is always correct, especially between 32 and 64 bits archs ?)
It's still wrong to do.
Cheers, Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |