lkml.org 
[lkml]   [2006]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 26/35] Unionfs: Privileged operations workqueue

    On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote:
    >+#include "union.h"
    >+
    >+struct workqueue_struct *sioq;
    >+
    >+int __init init_sioq(void)

    Although it's just me, I'd prefer sioq_init(), sioq_exit(),
    sioq_run(), etc. to go in hand with what most drivers use as naming
    (i.e. <modulename> "_" <function>).

    >+ sioq = create_workqueue("unionfs_siod");

    Beat me: what does SIO stand for?

    >+void fin_sioq(void)

    No __exit tag?

    >+void __unionfs_mknod(void *data)
    >+{
    >+ struct sioq_args *args = data;
    >+ struct mknod_args *m = &args->mknod;

    Care to make that: const struct mknod_args *m = &args->mknod;?
    (Same for other places)

    >+
    >+ args->err = vfs_mknod(m->parent, m->dentry, m->mode, m->dev);
    >+ complete(&args->comp);
    >+}
    >+void __unionfs_symlink(void *data)
    >+{

    Hah, missing free line :^)

    >+ struct sioq_args *args = data;
    >+ struct symlink_args *s = &args->symlink;
    >+
    >+ args->err = vfs_symlink(s->parent, s->dentry, s->symbuf, s->mode);
    >+ complete(&args->comp);
    >+}
    >+

    >+++ b/fs/unionfs/sioq.h
    >+struct isopaque_args {
    >+ struct dentry *dentry;
    >+};

    This name puzzled me at first. iso - paque - "same (o)paque"?
    Try is_opaque_args.

    >+/* Extern definitions for our privledge escalation helpers */

    -> privilege


    -`J'
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-05 20:37    [W:3.670 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site