lkml.org 
[lkml]   [2006]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [GFS2] Fix crc32 calculation in recovery.c [8/70]
    From
    Date
    Hi,

    On Sat, 2006-12-02 at 09:40 +0100, Jan Engelhardt wrote:
    > >Commit "[GFS2] split and annotate gfs2_log_head" resulted in an incorrect
    > >checksum calculation for log headers. This patch corrects the
    > >problem without resorting to copying the whole log header as
    > >the previous code used to.
    > >
    > >Cc: Al Viro <viro@zeniv.linux.org.uk>
    > >Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
    > >---
    > > fs/gfs2/recovery.c | 9 +++++----
    > > 1 files changed, 5 insertions(+), 4 deletions(-)
    > >
    > >diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
    > >index 4478162..4acf238 100644
    > >--- a/fs/gfs2/recovery.c
    > >+++ b/fs/gfs2/recovery.c
    > >@@ -136,6 +136,7 @@ static int get_log_header(struct gfs2_jd
    > > {
    > > struct buffer_head *bh;
    > > struct gfs2_log_header_host lh;
    > >+static const u32 nothing = 0;
    > > u32 hash;
    > > int error;
    > >
    >
    > At least indent it.
    >

    I've had a private email from someone pointing out the same thing. It
    was not intended to emphasise the fact that it is static, I'm not sure
    if thats the "right thing" or not, but either way, it doesn't actually
    need to be static, so that I've agreed that I'll remove the static and
    just leave it as const and fix the indenting at the same time,

    Steve.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-04 11:13    [W:7.918 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site