Messages in this thread | | | Subject | Re: [PATCH 32/36] driver core: Introduce device_move(): move a device to a new parent. | From | Marcel Holtmann <> | Date | Mon, 04 Dec 2006 22:15:03 +0100 |
| |
Hi Greg,
> > > Provide a function device_move() to move a device to a new parent device. Add > > > auxilliary functions kobject_move() and sysfs_move_dir(). > > > kobject_move() generates a new uevent of type KOBJ_MOVE, containing the > > > previous path (DEVPATH_OLD) in addition to the usual values. For this, a new > > > interface kobject_uevent_env() is created that allows to add further > > > environmental data to the uevent at the kobject layer. > > > > has this one been tested? I don't get it working. I always get an EINVAL > > when trying to move the TTY device of a Bluetooth RFCOMM link around. > > I relied on Cornelia to test this. I think some s390 patches depend on > this change, right?
my pre-condition is that the TTY device has no parent and then we move it to a Bluetooth ACL link as child. This however is not working or the TTY change to use device instead of class_device has broken something.
> > And shouldn't device_move(dev, NULL) re-attach it to the virtual device > > tree instead of failing? > > Yes, that would be good to have.
Cornelia, please fix this, because otherwise we can't detach a device from its parent. Storing the current virtual parent looks racy to me.
Regards
Marcel
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |