Messages in this thread | | | Date | Sun, 31 Dec 2006 12:37:15 -0800 (PST) | Subject | Re: [PATCH] net/core/flow.c: compare data with memcmp | From | David Miller <> |
| |
From: "Daniel_Marjamäki" <daniel.marjamaki@gmail.com> Date: Sun, 31 Dec 2006 17:37:05 +0100
> From: Daniel Marjamäki > This has been tested by me. > Signed-off-by: Daniel Marjamäki <daniel.marjamaki@gmail.com>
Please do not do this.
memcmp() cannot assume the alignment of the source and destination buffers and thus will run more slowly than that open-coded comparison.
That code was done like that on purpose because it is one of the most critical paths in the networking flow cache lookup which runs for every IPSEC packet going throught the system. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |