Messages in this thread | | | Date | Sun, 3 Dec 2006 09:15:52 +0100 | From | Adrian Bunk <> | Subject | Re: [2.6 patch] FW_LOADER should select HOTPLUG |
| |
On Sun, Dec 03, 2006 at 12:58:24AM -0800, Andrew Morton wrote: > On Sun, 3 Dec 2006 08:16:37 +0100 > Adrian Bunk <bunk@stusta.de> wrote: > > > Since FW_LOADER is an option that is always select'ed by the code using > > it, it mustn't depend on HOTPLUG. > > > > It's only relevant in the EMBEDDED=y case, but this might have resulted > > in illegal FW_LOADER=, HOTPLUG=n configurations. > > > > Signed-off-by: Adrian Bunk <bunk@stusta.de> > > > > --- linux-2.6.19-rc6-mm2/drivers/base/Kconfig.old 2006-12-02 20:36:49.000000000 +0100 > > +++ linux-2.6.19-rc6-mm2/drivers/base/Kconfig 2006-12-02 20:37:03.000000000 +0100 > > @@ -19,8 +19,8 @@ > > If unsure say Y here. > > > > config FW_LOADER > > - tristate "Userspace firmware loading support" > > - depends on HOTPLUG > > + tristate > > + select HOTPLUG > > It would be a retrograde step to start selecting HOTPLUG - we've managed to > avoid it thus far.
$ grep -r "select HOTPLUG" * | wc -l 4 $
> It'd be better to make those drivers which select FW_LOADER dependent upon > HOTPLUG.
$ grep -r "select FW_LOADER" * | wc -l 71 $
And since the only case where depends<->select makes a difference is CONFIG_EMBEDDED=y, people will always continue to forget the dependency on HOTPLUG when select'ing FW_LOADER.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |