Messages in this thread | | | Subject | Re: kobject_add unreachable code | From | Olaf Dietsche <> | Date | Fri, 29 Dec 2006 14:50:44 +0100 |
| |
Martin Stoilov <mstoilov@odesys.com> writes:
> The following code in kobject_add > if (!kobj->k_name) > kobj->k_name = kobj->name; > if (!kobj->k_name) { > pr_debug("kobject attempted to be registered with no name!\n"); > WARN_ON(1); > return -EINVAL; > } > > doesn't look right to me. The second 'if' statement looks useless after > the assignment in the first one. May be it was meant to be like: > if (!*kobj->k_name)
The second test is true, if kobj->name is NULL as well.
Regards, Olaf. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |