Messages in this thread | | | Date | Wed, 27 Dec 2006 17:53:44 +0000 | From | Pavel Machek <> | Subject | Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers |
| |
Hi!
> Arch-neutral GPIO calls for PXA. > > From: Philipp Zabel <philipp.zabel@gmail.com>
Missing s-o-b?
> +static inline int gpio_direction_input(unsigned gpio) > +{ > + if (gpio > PXA_LAST_GPIO) > + return -EINVAL; > + pxa_gpio_mode(gpio | GPIO_IN); > +}
Missing return 0?
> +static inline int gpio_direction_output(unsigned gpio) > +{ > + if (gpio > PXA_LAST_GPIO) > + return -EINVAL; > + pxa_gpio_mode(gpio | GPIO_OUT); > +} > +
And here?
Pavel -- Thanks for all the (sleeping) penguins. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |