Messages in this thread | | | From | Segher Boessenkool <> | Subject | Re: [powerpc] Fix bogus BUG_ON() in in hugetlb_get_unmapped_area() | Date | Fri, 22 Dec 2006 01:31:26 +0100 |
| |
> + if (len > TASK_SIZE) > + return -ENOMEM;
Shouldn't that be addr+len instead? The check looks incomplete otherwise. And you meant ">=" I guess?
> - /* Paranoia, caller should have dealt with this */ > - BUG_ON((addr + len) > 0x100000000UL); > -
Any real reason to remove the paranoia check? If it's trivially always satisfied, the compiler will get rid of it for you :-)
Cheers,
Segher
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |