lkml.org 
[lkml]   [2006]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file content corruption on ext3)


On Wed, 20 Dec 2006, Dave Kleikamp wrote:
>
> This patch removes some questionable code that attempted to make a
> no-longer-used page easier to reclaim.

If so, "cancel_dirty_page()" may actually be the right thing to use, but
only if you can guarantee that the page isn't mapped anywhere (and from
the name of the function I guess it's not something that you'll ever map?)

So the JFS code _looks_ like you could just replace the

clear_page_dirty(page);

with

cancel_dirty_page(page, PAGE_CACHE_SIZE);

(where that second parameter is just used for statistics - it updates the
"cancelled IO" byte-counts if CONFIG_TASK_IO_ACCOUNTING is set - so the
number doesn't really matter, you could make it zero if you never want the
thing to show up in the IO accounting).

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.247 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site