Messages in this thread | | | Date | Mon, 18 Dec 2006 10:04:39 +0000 (GMT) | From | Tigran Aivazian <> | Subject | Re: [PATCH] microcode: Fix mc_cpu_notifier section warning |
| |
Hi Jean,
Ok, your patch is correct, although I assume you realize that it does nothing --- both the function and the data it operates on are inside CONFIG_HOTPLUG_CPU and checking include/linux/init.h I see that __cpuinitdata is nothing in this case. E.g. msr_class_cpu_notifier in the msr driver isn't declared __cpuinitdata...
But to tidy up one should add __cpuinitdata as you suggest (to guard for the case if these two slip out of CONFIG_HOTPLUG_CPU, although they are meaningless if cpu hotplug support is not configured in).
Kind regards Tigran
On Sun, 17 Dec 2006, Jean Delvare wrote:
> Structure mc_cpu_notifier references a __cpuinit function, but > isn't declared __cpuinitdata itself: > > WARNING: arch/i386/kernel/microcode.o - Section mismatch: reference > to .init.text: from .data after 'mc_cpu_notifier' (at offset 0x118) > > Signed-off-by: Jean Delvare <khali@linux-fr.org> > --- > arch/i386/kernel/microcode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-2.6.20-rc1.orig/arch/i386/kernel/microcode.c 2006-12-15 09:05:20.000000000 +0100 > +++ linux-2.6.20-rc1/arch/i386/kernel/microcode.c 2006-12-17 15:23:40.000000000 +0100 > @@ -722,7 +722,7 @@ > return NOTIFY_OK; > } > > -static struct notifier_block mc_cpu_notifier = { > +static struct notifier_block __cpuinitdata mc_cpu_notifier = { > .notifier_call = mc_cpu_callback, > }; > > > > -- > Jean Delvare > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |