Messages in this thread | | | Date | Mon, 18 Dec 2006 14:32:22 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: 2.6.19 file content corruption on ext3 |
| |
On Mon, 18 Dec 2006, Andrei Popa wrote: > > > > This should be fairly easy to test: just change every single ", 1" case in > > the patch to ", 0". > > > > What happens for you in that case? > > I have file corruption.
Magic. And btw, _thanks_ for being such a great tester.
So now I have one more thng for you to try, it you can bother:
There's exactly two call sites that call "page_mkclean()" (an dthat is the only thing in turn that calls "page_mkclean_one()", which we already determined will cause the corruption).
Both of them do
if (mapping_cap_account_dirty(mapping)) { ..
things, although they do slightly different things inside that if in your patched kernel.
Can you just TOTALLY DISABLE that case for the test_clear_page_dirty() case? Just do an "#if 0 .. #endif" around that whole if-statement, leaving the _only_ thing that actually calls "page_mkclean()" to be the "clear_page_dirty_for_io()" call.
Do you still see corruption?
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |