Messages in this thread | | | Date | Sat, 16 Dec 2006 03:33:52 +0100 | From | Adrian Bunk <> | Subject | Re: [patch] include linux/types.h in a bunch of header files for usage with install_headers |
| |
On Fri, Dec 15, 2006 at 09:08:50PM -0500, Mike Frysinger wrote: > On 12/12/06, Adrian Bunk <bunk@stusta.de> wrote: > >On Wed, Dec 06, 2006 at 06:03:50PM -0500, Mike Frysinger wrote: > >> there are a plethora of headers that cannot be included straight due > >> to the usage of __ types (like __u32) without first including > >> linux/types.h ... so the question is, should all of these headers be > >> fixed to properly pull in linux/types.h first or are users expected to > >> "just know" the correct order of headers ? in my mind, pretty much > >> every header is fair game for straight "#include <header>" usage and > >> requiring a list of headers to be pulled in properly is ignoring the > >> problem ... > > > >Yes, they should all be fixed to #include <linux/types.h>. > > thanks, mondo patch attached :)
Looks good, but after your patch the following headers can be moved from unifdef-y to header-y: include/linux/atm.h include/linux/atmarp.h
> -mike
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |